Updating the progress

Hi Madhusudan,

Thu, Jun 05, 2008 at 02:48:51PM +0530, Madhusudan C.S wrote:

I have done few commits to be code today. I request you to please
check the code.

Well, not being familiar with libnetfs, I unfortunately can't really
tell whether the code makes sense.

I didn't discover any obvious errors when looking at it -- but then,
it's not surprising, considering that most of the code seems to be
template code more or less directly copied from some other translator(s)
:-)

I must again point out that if you copy code, you should mention (below
the copyright line) that the code is based on ftpfs (or whatever it is
based on), and include the copyright notice from the orignal file.

Aside from that, you are not following conventions in the commit
messages (which has very adverse effects on some git tools): You should
start each commit message with a single line summing up the commit, a
blank line, and only then a detailed description what you changed.

If you find that you can't sum up the commit in a single line, this most
probably means that you have several individual changes, which should
actually go into seperate commits From what I saw, this is often the
case.

Also, please check the diffs more closely before comitting: In several
commits you have changes that aren't mentioned in the commit message,
and in fact seem totally unrelated to the rest of the commit

BTW I wonder, why are you keeping build logs in git?

The major decisions were to use two separate structures for
directory handling, viz. procfs_dir and procfs_dir_entry(This was a
change from my previous thought of using the same structure for all
types of nodes).

I can't really comment on that -- I have no idea what these do :-)

-antrik-

Hi Madhusudan,

Mon, Jun 09, 2008 at 08:45:06PM +0530, Madhusudan C.S wrote:

Yes, some parts of the code is a template of other netfs translators.
But if seen keenly, nearly almost all the translators I am referring
follows the same template or rather have copied the template from one
another.

Which is perfectly resonable

To be on safer side I thought of using the template of ftpfs which is
in hurd main source only, since it is copyrighted to FSF.

Indeed, that's what I would suggest myself. Both for licensing reasons,
and for correctness -- after all, this code is written by the same
people who created the libraries :-)

I hope that will not have any adverse effect on my code in terms of
copyright and license issues.

No, not at all. But I do think you should mention where the code comes
from, and more importantly, the copyright dates of the original code.

BTW I wonder, why are you keeping build logs in git?

Aah I wanted to tell about that myself, when we discuss among our
friends about the progress, I usually used to tell about the silliest
programming errors we make during programming which leads to hours of
work to find and fix it. So many of them asked me to maintain a build
log so they can see how things are going, and also I thought it would
be nice for me to go through such things, because this is the first
big free software project I am doing that too from scratch. I
understand your concern that it would make the repository very big
unnecessarily. I wont be transferring that to Hurd CVS you provide us.
Is that ok or should I discontinue that from git?

Well, it's a bit unusual, but I have no real objections -- keep it if
you want :-)

-antrik-