Gnumach cleanup 10 second attempt

Here is an updated patch. I hope I got it right this time.

I added __attribute__ ((noreturn)) to i386_exception but I now get this
warning:

/i386/i386/trap.c: In function 'i386_exception':
/i386/i386/trap.c:634: warning: 'noreturn' function does return

But I don't see a return anywhere!??

Thanks,

Barry deFreese
Your favorite idiot.

Barry deFreese, le Mon 21 Jul 2008 11:01:31 -0400, a :
Here is an updated patch. I hope I got it right this time.

I added __attribute__ ((noreturn)) to i386_exception but I now get this
warning:

/i386/i386/trap.c: In function 'i386_exception':
/i386/i386/trap.c:634: warning: 'noreturn' function does return

But I don't see a return anywhere!??

Indeed, but functions implicitely return at the end of it

And in that case, that's why I said to add noreturn to i386_exception
and similar. exception() is one of those "similars".

Samuel

Samuel Thibault wrote:
<snip>
Indeed, but functions implicitely return at the end of it
>
And in that case, that's why I said to add noreturn to i386_exception
and similar. exception() is one of those "similars".
>
Samuel
>

Samuel,

K fair enough but exception() does do a few returns, you want me to go
ahead and remove those also?

Thanks,

Barry

Barry deFreese, le Mon 21 Jul 2008 11:33:57 -0400, a :
Samuel Thibault wrote:
><snip>
>Indeed, but functions implicitely return at the end of it
>
>And in that case, that's why I said to add noreturn to i386_exception
>and similar. exception() is one of those "similars".

K fair enough but exception() does do a few returns, you want me to go
ahead and remove those also?

See the comment, they shouldn't be reached, so yes you can, but also add
noreturn to the functions that are called just before, etc. ;)

Samuel

Samuel Thibault wrote:
Barry deFreese, le Mon 21 Jul 2008 11:33:57 -0400, a :

>Samuel Thibault wrote:
>
<snip>
Indeed, but functions implicitely return at the end of it

And in that case, that's why I said to add noreturn to i386_exception
and similar. exception() is one of those "similars".

>K fair enough but exception() does do a few returns, you want me to go
>ahead and remove those also?
>
>
See the comment, they shouldn't be reached, so yes you can, but also add
noreturn to the functions that are called just before, etc. ;)
>
Samuel

K I'm getting closer. I added noreturn to exception and
exception_raise but I'm still getting the warning that exception_raise
is returning. I thought maybe it was assert() but Asser() has
__attribute__ ((noreturn)). Any idea on what else I'm missing?

Sorry to be such a pain.

Thanks,

Barry

Barry deFreese, le Mon 21 Jul 2008 12:30:36 -0400, a :
Samuel Thibault wrote:
>See the comment, they shouldn't be reached, so yes you can, but also add
>noreturn to the functions that are called just before, etc. ;)
>
K I'm getting closer. I added noreturn to exception and
exception_raise but I'm still getting the warning that exception_raise
is returning.

There are return statements with /*NTREACHED*/ above to drop again and
functions to add noreturn to again, yes, exception_raise_continue_slow
for instance, etc., etc., etc. Yes you'll probably have to add noreturn
to a big bunch of functions, that's fine since they're supposed to be.

I thought maybe it was assert()

assert() doesn't "trigger" return.

but Asser() has __attribute__ ((noreturn)).

That's not at stake here since there's an if before it in the assert()
macro

Samuel