
July 6th, 2008, 01:20 PM
|
|
Guest
|
|
Posts: n/a
Time spent in forums:
Reputation Power:
|
|
|
segfault from sort if comparison is always1
Sat, 2008-07-05 at 20:11 -0700, Andrew Johnson wrote:
Parrot_quicksort() is in src/utils.c; the first do-while loop has nothing to
stop it when j reaches 0, so it keeps going outside of the data array. I
guess that the while condition needs j 0 adding to it to prevent that from
happening.
Better yet, we should replace the inherently insecure quicksort
algorithm (insecure in the "vulnerable to algorithmic attack" sense)
with a more secure mergesort like perl5 uses. IIRC, perl5's mergesort
is also carefully crafted to be as sensible as possible in the face of
insane compare functions
-'f
|