Configure.pl tests create bad dirs in $TMP

Wednesday 30 July 2008 11:20:33 Andy Dougherty wrote:

Ahh -- it's just an octal/decimal mix-up. Here's the patch:
>
2008-07-30 13:45:19.000000000
-0400 2008-07-30 14:15:44.000000000
-0400 @@ -228,7 +228,7 @@
my $expected_include_dir =
$expected_dir . $conf->data->get('slash') . q{include};
mkdir $expected_dir or croak "Unable to make testing directory";
- mkpath($expected_include_dir, 0, 755)
+ mkpath($expected_include_dir, 0, 0755)
or croak "Unable to make second-level testing directory";
($icuheaders, $without) =
$stephandle_icuheaders($conf, qq{$expected_dir\n}, 0);
>
>
Mind you, the directories still aren't cleaned up automatically, but this
at least makes that less tedious.

Good catch. Does this revision of the patch perform the cleanup
appropriately?

-- c

Wednesday 30 July 2008 12:10:32 Andy Dougherty wrote:

Yes, but we might as well clean up the other two cases as well. So this
goes on top of yours:
>
2008-07-30 15:05:43.000000000 -0400
2008-07-30 15:06:34.000000000 -0400
@@ -193,7 +193,7 @@
>
my $cwd = cwd();
{
- my $tdir = tempdir();
+ my $tdir = tempdir( CLEANUP =1);
chdir $tdir or croak "Unable to change to temporary directory";
my $expected_dir = q{alpha};
my $expected_include_dir =
@@ -207,7 +207,7 @@
}
>
{
- my $tdir = tempdir();
+ my $tdir = tempdir( CLEANUP =1);
chdir $tdir or croak "Unable to change to temporary directory";
my $expected_dir = q{alpha};
my $expected_include_dir =

Thanks, applied as r29881.

-- c