Konq bookmarks sidebar bug

Hi,
The attached patch, to be applied in
, seems to fix a
couple of bugs that affect the bookmarks in the sidebar. The problem is that
, which converts an address in the
bookmarks tree like "/5/6/7" into a pointer to the appropriate list item was
recursing one time too many and so returning the wrong thing.

Can anyone see any problems with the patch? If not, can I commit it?

Regards,
Philip

Hi,

Can anyone see any problems with the patch? If not, can I commit it?

Indeed, looks like a porting error.
QStringList::split should have been ported to
QString::split(, QString::SkipEmptyParts);
This might be safer than accessing [0], btw (e.g. if the
address is empty for some reason).

Ah yes, Pino mentioned to me that QString::skipEmptyParts might be a better
way to do it - I'll try that, and if it works, I'll commit unless someone
says otherwise.

Regards,
Philip