Ipa-prop overhaul and indirect inlining (PR 9079)

Hi,

Hi,
Thanks for doing all the work and cleaning up IPCP on the way ;)

The patch set had the biggest effect on libstdc++ performance tests
where there were 122 discovered indirect calls with know targets and
122 of them were inlined (these may not necessarily be the same as
inlining can duplicate these edges, during regression testing there
are more inlined indirect edges than discovered ones). The run-time
data I got for libstdc++ were a bit noisy. Three of the benchmarks
showed speedup of 13-22% speedup that could not be attributed to noise
and there was a few of others like this with performance increases
just below 10%. the other hand there is also one 12% slowdown that
also looks like not being caused by any noise. However, all these
numbers are preliminary, I will have to redo the measurements.

When compiling DLV there are 299 discovered indirect edges and 299 are
inlined but there is no apparent effect on runtime. 13 instances of
both occur on Tramp3D but that has no effect on runtime either.

This seems like expected result. This feature was originally requested
by libstdc++ people (mainliny Paolo). Benchmarks like tramp3d and DLV
rely on instantiating everything

Little amount of inlining of indirect calls is also covered by early
inliner (just for very simple wrappers).

Honza

Hi,
This seems like expected result. This feature was originally requested
by libstdc++ people (mainliny Paolo).
Thanks for acknowledging the need For example, the two cases in the
performance testcase



should show very similar results after the patch I would be happy to
check that myself, but I'm a little scared by the complexity of the
patch-set. Let's keep in touch, of course, please let me know if you
need some additional details or what else.

Thanks,
Paolo.

Hi,
>This seems like expected result. This feature was originally requested
>by libstdc++ people (mainliny Paolo).
Thanks for acknowledging the need For example, the two cases in the
performance testcase



should show very similar results after the patch I would be happy to
check that myself, but I'm a little scared by the complexity of the
patch-set. Let's keep in touch, of course, please let me know if you
need some additional details or what else.

The patch-set is not as complex as it seems, most of the code is actual
cleanup of IPCP. I am glad Martin chosed the harder way to get this
implemented ;))

Honza

Thanks,
Paolo.