Fix Werror breakage (maintainer-mode)

Can somebody enlighten me as to a proper locale_init.cc fix?

Yes, the warning is new and I'd like to understand whether the warning is worrisome or not, or even bogus. That's not clear to me, at the moment. As a LAST resort, the warning could be suppressed via the "usual" trick, something like:

const char* __p = reinterpret_cast<const char*>(c_locale);
return *reinterpret_cast<const locale*>(__p);

which I would consider a tad better than disabling -Werror selectively.

The unwind-pe.h change seems obviously safe to me.

Paolo.

Gabriel Dos Reis wrote on 06 July 2008 20:34:

Sun, Jul 6, 2008 at 7:51 AM, Richard Guenther
<richard.guenther@gmailwrote:

>The code does
>
>typedef char fake_locale[sizeof(locale)]
>__attribute__ ((aligned(__alignof__(locale))));
>fake_locale c_locale;

Say, isn't it invalid (or of uncertain validity) to place alignment
attributes on typedefs like that?

Notice that this idiom may become common place, now that C++0x has alignas
(the moral equivalent of GNU C++'s attribute above), along with the
library aligned_storage<template.

Hopefully that wouldn't suffer the same complications?

cheers,
DaveK
--
Can't think of a witty .sigline today